fix: query params are not getting parsed from curl #3931
+27
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanish-bruno
requested review from
ramki-bruno,
naman-bruno and
Pragadesh-45
and removed request for
naman-bruno
1 task
sanish-bruno
requested review from
Pragadesh44-Bruno
and removed request for
Pragadesh-45
| return query | ||
| .split('#')[0] | ||
| .split('&') | ||
| .map((param) => { |
There was a problem hiding this comment.
This entire thing can be simplified by:
.map((param) => {
const [name, value = ''] = param.split('=');
return { name, value };
})
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
previously we were passing the url without params while creating a request from curl, the grapgql/http detection still uses urls without params, but when creating a request from the curl, we will pass the raw url with params. in that way the params are not omitted while creation.
Additionally worked on multiline parameters, where encoded params where decoded and stored in the bru file resulting in invalid bru file, and it never gets loaded. now the encoded params, are stored as it is to avoid corruption on bru file
fixes #3924
fixes #3161
parse params
Screen.Recording.2025-02-04.at.1.26.14.PM.mov
multiline
Screen.Recording.2025-02-06.at.11.38.04.AM.mov
Contribution Checklist:
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.